Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

front: reorder and redefine map layer groups #10962

Merged
merged 1 commit into from
Mar 6, 2025
Merged

front: reorder and redefine map layer groups #10962

merged 1 commit into from
Mar 6, 2025

Conversation

Synar
Copy link
Contributor

@Synar Synar commented Feb 26, 2025

Close #8302

@Synar Synar requested a review from a team as a code owner February 26, 2025 13:24
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Feb 26, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 26, 2025 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.63%. Comparing base (57034a3) to head (fdb6f17).
Report is 98 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##              dev   #10962      +/-   ##
==========================================
- Coverage   82.56%   80.63%   -1.93%     
==========================================
  Files        1087     1101      +14     
  Lines      108129   112343    +4214     
  Branches      742      749       +7     
==========================================
+ Hits        89272    90586    +1314     
- Misses      18815    21714    +2899     
- Partials       42       43       +1
Flag Coverage Δ
editoast 72.18% <ø> (-2.22%) ⬇️
front 89.92% <100.00%> (-0.46%) ⬇️
gateway 2.18% <ø> (ø)
osrdyne 2.53% <ø> (-0.76%) ⬇️
railjson_generator 87.58% <ø> (ø)
tests 87.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Synar Synar force-pushed the ali/reorder-map-layers-in-front branch from 90fbff6 to 56872dd Compare February 26, 2025 16:22
@jacomyal
Copy link
Contributor

LGTM 👍

@Synar Synar requested a review from clarani February 26, 2025 19:17
clarani
clarani reviewed Feb 27, 2025
View reviewed changes
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice refacto 🙏

However, I'm not sure it solves the bug :/
I can still have the speed limits over the punctual elements
Capture vidéo du 2025-02-27 11-47-49.webm

@Synar
Copy link
Contributor Author

Synar commented Feb 27, 2025 •
edited
Loading

Sorry, my bad, I was so convinced the above suggestion would work right out of the gate I did not test it. Turns out symbols are not keys, and so Object.keys does not return them. So the map had 0 virtual layers, and so ordering was completely broken. Replacing Object.keys with Object.getOwnPropertySymbols works as intended. '^^

Can you try again @clarani ?

@Synar Synar requested a review from clarani February 27, 2025 14:18
clarani
clarani approved these changes Mar 5, 2025
View reviewed changes
Copy link
Contributor

@clarani clarani left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅
It works very well, thanks !!

@Synar Synar force-pushed the ali/reorder-map-layers-in-front branch from 9ff4a44 to fdb6f17 Compare March 6, 2025 12:46
@Synar Synar enabled auto-merge March 6, 2025 12:46
@Synar Synar disabled auto-merge March 6, 2025 13:17
@Synar Synar enabled auto-merge March 6, 2025 14:57
@Synar Synar added this pull request to the merge queue Mar 6, 2025
Merged via the queue into dev with commit 28261be Mar 6, 2025
27 checks passed
@Synar Synar deleted the ali/reorder-map-layers-in-front branch March 6, 2025 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacomyal jacomyal jacomyal approved these changes

@clarani clarani clarani approved these changes

Assignees
No one assigned
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Infra editor : Speed restriction edition switches not visible
4 participants
@Synar @codecov-commenter @jacomyal @clarani